Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for testing print styles in Chromatic #315

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Adds docs for testing print styles in Chromatic #315

merged 2 commits into from
Nov 21, 2023

Conversation

elseloop
Copy link
Contributor

@elseloop elseloop commented Nov 20, 2023

  • adds new section to /docs/media-features
  • used info from this Slack thread and this PR
  • I decided to explicitly call out and document the lack of Modes support, as it seems an easy assumption one might make and having 🚨 THIS WILL NOT WORK 🚨 in a code snippet seems a good deterrent

@jmhobbs Can you please make sure this sounds accurate to you?

A direct link to updated section.

@elseloop elseloop requested review from jmhobbs and domyen November 20, 2023 21:33
Copy link

github-actions bot commented Nov 20, 2023

@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 21:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 21:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 21:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 21:43 Inactive
Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads accurately to me!

@domyen
Copy link
Member

domyen commented Nov 20, 2023

New info

Do any of the media features work with modes? No, none of them do.

@elseloop The way the current page is written, it suggests that only print doesn't work with modes. Apparently, none of the media features work with modes.

I'd suggest the page gets updated to turn the modes piece into a dropdown. That way it feels more approachable.

@elseloop
Copy link
Contributor Author

I'd suggest the page gets updated to turn the modes piece into a dropdown. That way it feels more approachable.

Oh, I definitely didn't realize that none of them work with Modes. Totally makes sense to update the page so it's more reflective of that.

@domyen What do you mean to turn the modes piece into a dropdown?

@domyen
Copy link
Member

domyen commented Nov 21, 2023

@elseloop I made the updates I suggested.

@github-actions github-actions bot temporarily deployed to pull request November 21, 2023 00:02 Inactive
@elseloop elseloop merged commit 71af270 into main Nov 21, 2023
4 checks passed
@elseloop elseloop deleted the dan/print branch November 21, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants